swiftlint: exclude vendored swift-system and swift-mutex (4487 → 351) #18

Merged

founder merged 1 commit from swiftlint-exclude-vendored into main

2026-07-26 21:33:11 +00:00

founder commented

2026-07-26 21:29:40 +00:00

Owner

Build: Apple has been red since at least 2026-07-20 with 4487 violations across 223 files — a number nobody can act on, blocking the signal for every unrelated PR.

91% was one vendored dependency. The excluded list already carves out swift-crypto, swift-syntax, swift-java, swift-flake, but was never extended when swift-system (Apache-2.0, Apple upstream) and swift-mutex (MIT) were vendored in. Our rules describe our house style and say nothing useful about imported sources.

	violations
before	4487
after	351

The remaining 351 are real findings in our code: KeyStorePersistence 170, KeyStoreKaiOSCore 47, Apple/FileProvider 33, KeyStoreModel 25, long tail.

Deliberately did not run swiftlint --fix: it corrected 149 files but only moved 351→317, and pushed Indentation Width violations up from 31 to 63. A 42-file reformat belongs in its own reviewable change.

🤖 Generated with Claude Code

`Build: Apple` has been red since at least 2026-07-20 with **4487 violations across 223 files** — a number nobody can act on, blocking the signal for every unrelated PR. **91% was one vendored dependency.** The `excluded` list already carves out `swift-crypto`, `swift-syntax`, `swift-java`, `swift-flake`, but was never extended when `swift-system` (Apache-2.0, Apple upstream) and `swift-mutex` (MIT) were vendored in. Our rules describe our house style and say nothing useful about imported sources. | | violations | |---|---| | before | 4487 | | after | **351** | The remaining 351 are real findings in our code: KeyStorePersistence 170, KeyStoreKaiOSCore 47, Apple/FileProvider 33, KeyStoreModel 25, long tail. **Deliberately did not run `swiftlint --fix`:** it corrected 149 files but only moved 351→317, and pushed Indentation Width violations *up* from 31 to 63. A 42-file reformat belongs in its own reviewable change. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

founder added 1 commit

2026-07-26 21:29:40 +00:00

swiftlint: exclude vendored swift-system and swift-mutex 9961ba975a

Build: Apple has been red since at least 2026-07-20 with 4487 violations across
223 files, which made the check useless -- nobody can act on that number, and it
blocked the signal for every unrelated PR.

91% of it was one vendored dependency. The excluded list already carves out
swift-crypto, swift-syntax, swift-java, and swift-flake, but was never extended
when swift-system (Apache-2.0, Apple upstream) and swift-mutex (MIT) were
vendored into Packages/. They are linted by their own projects; our rules --
indentation width, attribute placement, type contents order -- describe our
house style and say nothing useful about imported sources.

Excluding them takes the count from 4487 to 351, and those 351 are real findings
in our own code: KeyStorePersistence (170), KeyStoreKaiOSCore (47),
Apple/FileProvider (33), KeyStoreModel (25), and a long tail.

Deliberately not running `swiftlint --fix` here. It corrected 149 files but only
moved 351 -> 317, and pushed Indentation Width violations up from 31 to 63 --
it introduces as much as it repairs, and a 42-file reformat belongs in its own
reviewable change rather than riding along with a config fix.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>